3
97%
master: 97%

Ran 04 Oct 2019 08:17PM UTC

Files 97

Run time 7s

Badge

Embed ▾

Committed 04 Oct 2019 08:16PM UTC coverage: 96.201% (+0.02%) from 96.186%

Job # 2.5

Build Type

push

travis-ci

Committed by

brandur-stripe

Commit Message

Nicer error when specifying non-nil non-string opt value (#861)

Previously, if you specified a non-nil non-string opt value, like a
symbol for `idempotency_key`, you'd get a pretty user-unfriendly error
from `Net::HTTP`:

```
/Users/brandur/.rbenv/versions/2.4.5/lib/ruby/2.4.0/net/http/header.rb:21:in `block in initialize_http_header': undefined method `strip' for :foo:Symbol (NoMethodError)
```

Here, we introduce a new argument error that makes it a little easier
for someone to read. The impetus for the change is that we had an
internal product quality report where someone ran into this and was
confused.

I'm pretty sure this change is backward compatible because `Net::HTTP`
would call `strip` on anything that was passed in as a value, and
generally just strings would support that. There may be some other less
common data type that was accidentally compatible that someone was
using, but that case should be quite unusual.

Run Details

1950 of 2027 relevant lines covered (96.2%)

616.25 hits per line

stripe / stripe-ruby / 3482 / 3
97%
master: 97%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 3482.3 (2.5)

stripe / stripe-ruby / 3482 / 3 97% master: 97%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 3482.3 (2.5)

stripe / stripe-ruby / 3482 / 3
97%
master: 97%

README BADGES
x