3482
97%

Ran 04 Oct 2019 08:17PM UTC

Jobs 5

Files 291

Run time 2min

Badge

Embed ▾

pending completion

Build # 3482

Build Type

push

travis-ci

Committed by

brandur-stripe

Commit Message

Nicer error when specifying non-nil non-string opt value (#861)

Previously, if you specified a non-nil non-string opt value, like a
symbol for `idempotency_key`, you'd get a pretty user-unfriendly error
from `Net::HTTP`:

```
/Users/brandur/.rbenv/versions/2.4.5/lib/ruby/2.4.0/net/http/header.rb:21:in `block in initialize_http_header': undefined method `strip' for :foo:Symbol (NoMethodError)
```

Here, we introduce a new argument error that makes it a little easier
for someone to read. The impetus for the change is that we had an
internal product quality report where someone ran into this and was
confused.

I'm pretty sure this change is backward compatible because `Net::HTTP`
would call `strip` on anything that was passed in as a value, and
generally just strings would support that. There may be some other less
common data type that was accidentally compatible that someone was
using, but that case should be quite unusual.

Run Details

5687 of 5918 relevant lines covered (96.1%)

2428.81 hits per line

Jobs

ID	Job ID	Ran	Coverage
1	3482.1 (2.3)	04 Oct 2019 08:17PM UTC	96.2	Travis Job 3482.1
2	3482.2 (2.4)	04 Oct 2019 08:17PM UTC	96.2	Travis Job 3482.2
3	3482.3 (2.5)	04 Oct 2019 08:17PM UTC	96.2	Travis Job 3482.3
4	3482.4 (2.6)	04 Oct 2019 08:17PM UTC	96.17	Travis Job 3482.4
5	3482.5 (jruby-9.2.7.0)	04 Oct 2019 08:20PM UTC	0.0	Travis Job 3482.5

Source Files on build 3482

Detailed source file information is not available for this build.

stripe / stripe-ruby / 3482
97%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 3482

stripe / stripe-ruby / 3482 97%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 3482

stripe / stripe-ruby / 3482
97%

README BADGES
x