6
70%
develop: 70%

Ran 03 Oct 2019 11:32AM UTC

Files 407

Run time 43s

Badge

Embed ▾

Committed 03 Oct 2019 11:12AM UTC coverage: 68.333% (-0.06%) from 68.394%

Job # TEST_AIIDA_BACKEND=django TEST_TYPE="tests"

Build Type

push

travis-ci

Committed by

sphuber

Commit Message

Fix the validation of links in archive import (#3354)

The import logic imports the links after all the nodes have been
imported. The link validation, however, was incorrect. It included link
types only implicitly and `CALL` links were not even considered. Instead
of the convoluted nested try-except blocks, the `validate_link` utility
from `aiida.orm.utils.links` is used instead. This might not be the most
efficient way, since it goes through the front-end ORM but at least we
know it is correct.

Unfortunately, for Django, the validation cannot be done through the
front-end infrastructure because the query builder will go through the
SqlAlchemy, but the nodes that have been added during the import will
not be present in it, as they are managed by the Django transaction.
The only solution then is to perform the link validation manually.

Run Details

22379 of 32750 relevant lines covered (68.33%)

0.68 hits per line

aiidateam / aiida-core / 7157 / 6
70%
develop: 70%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 7157.6 (TEST_AIIDA_BACKEND=django TEST_TYPE="tests")

aiidateam / aiida-core / 7157 / 6 70% develop: 70%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 7157.6 (TEST_AIIDA_BACKEND=django TEST_TYPE="tests")

aiidateam / aiida-core / 7157 / 6
70%
develop: 70%

README BADGES
x