7157
70%

Ran 03 Oct 2019 11:24AM UTC

Jobs 4

Files 821

Run time 10min

Badge

Embed ▾

pending completion

Build # 7157

Build Type

push

travis-ci

Committed by

sphuber

Commit Message

Fix the validation of links in archive import (#3354)

The import logic imports the links after all the nodes have been
imported. The link validation, however, was incorrect. It included link
types only implicitly and `CALL` links were not even considered. Instead
of the convoluted nested try-except blocks, the `validate_link` utility
from `aiida.orm.utils.links` is used instead. This might not be the most
efficient way, since it goes through the front-end ORM but at least we
know it is correct.

Unfortunately, for Django, the validation cannot be done through the
front-end infrastructure because the query builder will go through the
SqlAlchemy, but the nodes that have been added during the import will
not be present in it, as they are managed by the Django transaction.
The only solution then is to perform the link validation manually.

Run Details

47076 of 65830 relevant lines covered (71.51%)

2.75 hits per line

Jobs

ID	Job ID	Ran	Coverage
5	7157.5 (TEST_AIIDA_BACKEND=django TEST_TYPE="tests")	03 Oct 2019 11:24AM UTC	68.42	Travis Job 7157.5
6	7157.6 (TEST_AIIDA_BACKEND=django TEST_TYPE="tests")	03 Oct 2019 11:32AM UTC	68.33	Travis Job 7157.6
7	7157.7 (TEST_AIIDA_BACKEND=sqlalchemy TEST_TYPE="tests")	03 Oct 2019 11:33AM UTC	69.28	Travis Job 7157.7
8	7157.8 (TEST_AIIDA_BACKEND=sqlalchemy TEST_TYPE="tests")	03 Oct 2019 11:34AM UTC	69.2	Travis Job 7157.8

Source Files on build 7157

Detailed source file information is not available for this build.

aiidateam / aiida-core / 7157
70%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 7157

aiidateam / aiida-core / 7157 70%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 7157

aiidateam / aiida-core / 7157
70%

README BADGES
x