• Home
  • Features
  • Pricing
  • Docs
  • Announcements
  • Sign In

aiidateam / aiida-core / 7157
70%

Build:
DEFAULT BRANCH: develop
Ran 03 Oct 2019 11:24AM UTC
Jobs 4
Files 821
Run time 10min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst

pending completion
7157

push

travis-ci

sphuber
Fix the validation of links in archive import (#3354)

The import logic imports the links after all the nodes have been
imported. The link validation, however, was incorrect. It included link
types only implicitly and `CALL` links were not even considered. Instead
of the convoluted nested try-except blocks, the `validate_link` utility
from `aiida.orm.utils.links` is used instead. This might not be the most
efficient way, since it goes through the front-end ORM but at least we
know it is correct.

Unfortunately, for Django, the validation cannot be done through the
front-end infrastructure because the query builder will go through the
SqlAlchemy, but the nodes that have been added during the import will
not be present in it, as they are managed by the Django transaction.
The only solution then is to perform the link validation manually.

47076 of 65830 relevant lines covered (71.51%)

2.75 hits per line

Jobs
ID Job ID Ran Files Coverage
5 7157.5 (TEST_AIIDA_BACKEND=django TEST_TYPE="tests") 03 Oct 2019 11:24AM UTC 0
68.42
Travis Job 7157.5
6 7157.6 (TEST_AIIDA_BACKEND=django TEST_TYPE="tests") 03 Oct 2019 11:32AM UTC 0
68.33
Travis Job 7157.6
7 7157.7 (TEST_AIIDA_BACKEND=sqlalchemy TEST_TYPE="tests") 03 Oct 2019 11:33AM UTC 0
69.28
Travis Job 7157.7
8 7157.8 (TEST_AIIDA_BACKEND=sqlalchemy TEST_TYPE="tests") 03 Oct 2019 11:34AM UTC 0
69.2
Travis Job 7157.8
Source Files on build 7157
Detailed source file information is not available for this build.
  • Back to Repo
  • Travis Build #7157
  • b2492e28 on github
  • Prev Build on develop (#7152)
  • Next Build on develop (#7164)
STATUS · Troubleshooting · Open an Issue · Sales · Support · CAREERS · ENTERPRISE · START FREE · SCHEDULE DEMO
ANNOUNCEMENTS · TWITTER · TOS & SLA · Supported CI Services · What's a CI service? · Automated Testing

© 2026 Coveralls, Inc