5
91%
master: 91%

Ran 10 Apr 2015 04:17AM UTC

Files 105

Run time 25s

Badge

Embed ▾

Committed 10 Apr 2015 04:00AM UTC coverage: 88.014% (+24.1%) from 63.916%

Job # jruby-19mode

Build Type

push

travis-ci

Committed by

sds

Commit Message

Protect against lost changes when setup_environment fails

Commit c3d972d4 fixed an issue where we would not restore changes in the
event a plugin failed to load. Unfortunately, it introduced a regression
where if `setup_environment` were to raise an error for any reason we
would always call `cleanup_environment`.

This is not necessarily always safe. For example, in the case of
pre-commit, `setup_environment` might fail before it is able to create a
stash of the working tree, so calling `cleanup_environment` could result
in lost changes.

Change the ordering so that we (hopefully) get the best of both worlds:

  * Call `load_hooks` first outside of the `begin`/`ensure` block so
    that if it fails we haven't touched the repository yet, so the repo
    won't be in a bad state if a plugin can't be loaded or a signature
    is invalid

  * Call `setup_environment` outside of the `begin`/`ensure` block so
    that in the worst case we don't accidentally clobber anything with
    `cleanup_environment`

Run Details

1711 of 1944 relevant lines covered (88.01%)

11.45 hits per line

sds / overcommit / 745 / 5
91%
master: 91%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 745.5 (jruby-19mode)

sds / overcommit / 745 / 5 91% master: 91%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 745.5 (jruby-19mode)

sds / overcommit / 745 / 5
91%
master: 91%

README BADGES
x