745
91%

Ran 10 Apr 2015 04:13AM UTC

Jobs 5

Files 105

Run time 4min

Badge

Embed ▾

pending completion

Build # 745

Build Type

push

travis-ci

Committed by

sds

Commit Message

Protect against lost changes when setup_environment fails

Commit c3d972d4 fixed an issue where we would not restore changes in the
event a plugin failed to load. Unfortunately, it introduced a regression
where if `setup_environment` were to raise an error for any reason we
would always call `cleanup_environment`.

This is not necessarily always safe. For example, in the case of
pre-commit, `setup_environment` might fail before it is able to create a
stash of the working tree, so calling `cleanup_environment` could result
in lost changes.

Change the ordering so that we (hopefully) get the best of both worlds:

  * Call `load_hooks` first outside of the `begin`/`ensure` block so
    that if it fails we haven't touched the repository yet, so the repo
    won't be in a bad state if a plugin can't be loaded or a signature
    is invalid

  * Call `setup_environment` outside of the `begin`/`ensure` block so
    that in the worst case we don't accidentally clobber anything with
    `cleanup_environment`

Run Details

1876 of 2123 relevant lines covered (88.37%)

102.71 hits per line

Jobs

ID	Job ID	Ran	Coverage
1	745.1 (1.9.3)	10 Apr 2015 04:13AM UTC	89.22	Travis Job 745.1
2	745.2 (2.0)	10 Apr 2015 04:13AM UTC	89.19	Travis Job 745.2
3	745.3 (2.1)	10 Apr 2015 04:13AM UTC	89.19	Travis Job 745.3
5	745.5 (jruby-19mode)	10 Apr 2015 04:17AM UTC	88.01	Travis Job 745.5
6	745.6 (rbx-2)	10 Apr 2015 04:17AM UTC	93.57	Travis Job 745.6

Source Files on build 745

Detailed source file information is not available for this build.

sds / overcommit / 745
91%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 745

sds / overcommit / 745 91%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 745

sds / overcommit / 745
91%

README BADGES
x