5
70%
develop: 70%

Ran 25 Sep 2019 09:19AM UTC

Files 405

Run time 59s

Badge

Embed ▾

Committed 25 Sep 2019 09:05AM UTC coverage: 68.414% (+0.006%) from 68.408%

Job # TEST_AIIDA_BACKEND=django TEST_TYPE="tests"

Build Type

push

travis-ci

Committed by

web-flow

Commit Message

Fix unspecific flush in `DjangoNode` causing data override (#3344)

The methods of `DjangoNode` related to the mutation of attributes and
extras were indirectly causing a flush of the entire node state instead
of flushing only the property they were mutating. For example, changing
the extras, would also cause the attributes to be flushed. This could
lead to problems, if the attributes had been changed in another instance
and flushed to the database, because the original instance will not
refresh the state of the attributes when flushing its state, these
changes will be overridden.

The `SqlaNode` properly avoided this problem by "flagging" the changed
property before calling the flush. This is done by a SqlAlchemy utility
function which is not present for Django. Instead we pipe this through
to the `DbNode.save` method which supports the `updated_fields` argument
to target only specific model fields to be flushed.

Run Details

22390 of 32727 relevant lines covered (68.41%)

0.68 hits per line

aiidateam / aiida-core / 7075 / 5
70%
develop: 70%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 7075.5 (TEST_AIIDA_BACKEND=django TEST_TYPE="tests")

aiidateam / aiida-core / 7075 / 5 70% develop: 70%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 7075.5 (TEST_AIIDA_BACKEND=django TEST_TYPE="tests")

aiidateam / aiida-core / 7075 / 5
70%
develop: 70%

README BADGES
x