7075
70%

Ran 25 Sep 2019 09:19AM UTC

Jobs 4

Files 773

Run time 9min

Badge

Embed ▾

pending completion

Build # 7075

Build Type

push

travis-ci

Committed by

web-flow

Commit Message

Fix unspecific flush in `DjangoNode` causing data override (#3344)

The methods of `DjangoNode` related to the mutation of attributes and
extras were indirectly causing a flush of the entire node state instead
of flushing only the property they were mutating. For example, changing
the extras, would also cause the attributes to be flushed. This could
lead to problems, if the attributes had been changed in another instance
and flushed to the database, because the original instance will not
refresh the state of the attributes when flushing its state, these
changes will be overridden.

The `SqlaNode` properly avoided this problem by "flagging" the changed
property before calling the flush. This is done by a SqlAlchemy utility
function which is not present for Django. Instead we pipe this through
to the `DbNode.save` method which supports the `updated_fields` argument
to target only specific model fields to be flushed.

Run Details

43411 of 59803 relevant lines covered (72.59%)

2.78 hits per line

Jobs

ID	Job ID	Ran	Coverage
5	7075.5 (TEST_AIIDA_BACKEND=django TEST_TYPE="tests")	25 Sep 2019 09:19AM UTC	68.41	Travis Job 7075.5
6	7075.6 (TEST_AIIDA_BACKEND=django TEST_TYPE="tests")	25 Sep 2019 09:26AM UTC	68.33	Travis Job 7075.6
7	7075.7 (TEST_AIIDA_BACKEND=sqlalchemy TEST_TYPE="tests")	25 Sep 2019 09:25AM UTC	69.37	Travis Job 7075.7
8	7075.8 (TEST_AIIDA_BACKEND=sqlalchemy TEST_TYPE="tests")	25 Sep 2019 09:26AM UTC	69.29	Travis Job 7075.8

Source Files on build 7075

Detailed source file information is not available for this build.

aiidateam / aiida-core / 7075
70%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 7075

aiidateam / aiida-core / 7075 70%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 7075

aiidateam / aiida-core / 7075
70%

README BADGES
x