isislovecruft
/
bridgedb
/
935
/
3
80%
develop: 91%
develop: 91%
|
Ran
|
Files
38
|
Run time
4s
|
Badge
Embed ▾
README BADGES
|
coverage: 79.594%. Remained the same
push
travis-ci
isislovecruftWhy were there ever unreachable subhashrings? Kill them with fire. As part of #4297, $SOMEONE added the prepopulateRings() methods, which are used when BridgeDB parses incoming descriptors. These methods add subhashrings and allocate bridges to them. When a client requests bridges, they are either requesting IPv4 or IPv6 bridges, and thus clients *always* have either filterBridgesByIPv4 or filterBridgesByIPv6, respectively. So why is there an extra subhashring with no IP version filters if clients *can never get to it*? Blame $SOMEONE. The $SOMEONE who authored the commit below would be a good start. * BUGFIX on e6ce57e72. * REMOVE the "filterless" subhashring from the IPBasedDistributor. * UPDATE documentation for IPBasedDistributor.prepopulateRings().
3530 of 4435 relevant lines covered (79.59%)
0.8 hits per line
Source Files on job 935.3 (TWISTED_VERSION=15.0.0 PYOPENSSL_VERSION=0.14)
| Coverage | ∆ | File | Lines | Relevant | Covered | Missed | Hits/Line |
|---|