isislovecruft
/
bridgedb
/
935
80%
develop: 91%
develop: 91%
|
Ran
|
Jobs
3
|
Files
38
|
Run time
2min
|
Badge
Embed ▾
README BADGES
|
push
travis-ci
isislovecruftWhy were there ever unreachable subhashrings? Kill them with fire. As part of #4297, $SOMEONE added the prepopulateRings() methods, which are used when BridgeDB parses incoming descriptors. These methods add subhashrings and allocate bridges to them. When a client requests bridges, they are either requesting IPv4 or IPv6 bridges, and thus clients *always* have either filterBridgesByIPv4 or filterBridgesByIPv6, respectively. So why is there an extra subhashring with no IP version filters if clients *can never get to it*? Blame $SOMEONE. The $SOMEONE who authored the commit below would be a good start. * BUGFIX on e6ce57e72. * REMOVE the "filterless" subhashring from the IPBasedDistributor. * UPDATE documentation for IPBasedDistributor.prepopulateRings().
3534 of 4435 relevant lines covered (79.68%)
2.39 hits per line
Jobs
| ID | Job ID | Ran | Files | Coverage | |
|---|---|---|---|---|---|
| 1 | 935.1 (TWISTED_VERSION=13.2.0 PYOPENSSL_VERSION=0.13.1) | 38 |
79.44 |
Travis Job 935.1 | |
| 2 | 935.2 (TWISTED_VERSION=14.0.2 PYOPENSSL_VERSION=0.14) | 38 |
79.59 |
Travis Job 935.2 | |
| 3 | 935.3 (TWISTED_VERSION=15.0.0 PYOPENSSL_VERSION=0.14) | 38 |
79.59 |
Travis Job 935.3 |
Source Files on build 935
| Coverage | ∆ | File | Lines | Relevant | Covered | Missed | Hits/Line |
|---|