4
86%
master: 86%

Ran 20 Sep 2019 01:15AM UTC

Files 489

Run time 22s

Badge

Embed ▾

Committed 19 Sep 2019 10:11PM UTC coverage: 85.88% (+0.01%) from 85.868%

Job # MODE=dynamic

Build Type

push

travis-ci

Committed by

fhunleth

Commit Message

Fix warning from coverity

This fixes:

*** CID 302877:  Error handling issues  (NEGATIVE_RETURNS)
/src/fwup.c: 602 in main()
596                 // This is a regular file, so open it the regular way.
597                 output_fd = open(mmc_device_path, O_RDWR | O_CREAT | O_WIN32_BINARY, 0644);
598
599                 // Get the original file length
600                 // NOTE: this call is not so interesting. The interesting one is for real
601                 //       media, but we need to do it anyway. <= 0 means unknown.
>>>     CID 302877:  Error handling issues  (NEGATIVE_RETURNS)
>>>     "output_fd" is passed to a parameter that cannot be negative.
602                 end_offset = lseek(output_fd, 0, SEEK_END);
603
604                 struct stat st;
605                 if (output_fd >= 0 && (fstat(output_fd, &st) < 0 || (st.st_mode & 0222) == 0)) {
606                     // The file permissions are read-only, but the user was able to
607                     // open it writable. Root can do this. This is almost certainly

Run Details

3035 of 3534 relevant lines covered (85.88%)

27911.19 hits per line

fhunleth / fwup / 1239 / 4
86%
master: 86%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 1239.4 (MODE=dynamic)

fhunleth / fwup / 1239 / 4 86% master: 86%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 1239.4 (MODE=dynamic)

fhunleth / fwup / 1239 / 4
86%
master: 86%

README BADGES
x