1239
86%

Ran 20 Sep 2019 01:15AM UTC

Jobs 1

Files 489

Run time 23s

Badge

Embed ▾

pending completion

Build # 1239

Build Type

push

travis-ci

Committed by

fhunleth

Commit Message

Fix warning from coverity

This fixes:

*** CID 302877:  Error handling issues  (NEGATIVE_RETURNS)
/src/fwup.c: 602 in main()
596                 // This is a regular file, so open it the regular way.
597                 output_fd = open(mmc_device_path, O_RDWR | O_CREAT | O_WIN32_BINARY, 0644);
598
599                 // Get the original file length
600                 // NOTE: this call is not so interesting. The interesting one is for real
601                 //       media, but we need to do it anyway. <= 0 means unknown.
>>>     CID 302877:  Error handling issues  (NEGATIVE_RETURNS)
>>>     "output_fd" is passed to a parameter that cannot be negative.
602                 end_offset = lseek(output_fd, 0, SEEK_END);
603
604                 struct stat st;
605                 if (output_fd >= 0 && (fstat(output_fd, &st) < 0 || (st.st_mode & 0222) == 0)) {
606                     // The file permissions are read-only, but the user was able to
607                     // open it writable. Root can do this. This is almost certainly

Run Details

3035 of 3534 relevant lines covered (85.88%)

27911.19 hits per line

Jobs

ID	Job ID	Ran	Files	Coverage
4	1239.4 (MODE=dynamic)	20 Sep 2019 01:15AM UTC	0	85.88	Travis Job 1239.4

Source Files on build 1239

Detailed source file information is not available for this build.

fhunleth / fwup / 1239
86%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 1239

fhunleth / fwup / 1239 86%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 1239

fhunleth / fwup / 1239
86%

README BADGES
x