4
100%
master: 100%

Ran 19 Aug 2019 03:05AM UTC

Files 1

Run time 0s

Badge

Embed ▾

Committed 19 Aug 2019 03:03AM UTC coverage: 100.0%. Remained the same

Job # 382.4

Build Type

Pull #180

travis-ci

Committed by

web-flow

Commit Message

Adding work to resolve issue 172: If a user decides to use signed cookies, only one of the 'koa:sess' cookies are correctly destroyed by the browser when the data is set to 'null'. This change fixes that by ensuring that the maxAge is always set when destroying the cookie, and the 'koa:sess.sig' cookies are also destroyed.

Changes:
- On destroy, set 'maxAge' to be false
- On destroy, set the 'expires' flag to be UNIXTIME epoch, which the 'Cookie' module relies on
- Added test case for the cookie time being set

Added test to assert that the .sig cookie is expired when 'signed: true'

Pull Request Pull Request #180: #172: Correctly expire cookies for nullified sessions

Coverage Stats

8 of 8 relevant lines covered (100.0%)

25.13 hits per line

koajs / session / 382 / 4
100%
master: 100%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 382.4

koajs / session / 382 / 4 100% master: 100%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 382.4

koajs / session / 382 / 4
100%
master: 100%

README BADGES
x