382
100%
master: 100%

Ran 19 Aug 2019 03:05AM UTC

Jobs 4

Files 1

Run time 17s

Badge

Embed ▾

pending completion

Build # 382

Build Type

Pull #180

travis-ci

Committed by

web-flow

Commit Message

Adding work to resolve issue 172: If a user decides to use signed cookies, only one of the 'koa:sess' cookies are correctly destroyed by the browser when the data is set to 'null'. This change fixes that by ensuring that the maxAge is always set when destroying the cookie, and the 'koa:sess.sig' cookies are also destroyed.

Changes:
- On destroy, set 'maxAge' to be false
- On destroy, set the 'expires' flag to be UNIXTIME epoch, which the 'Cookie' module relies on
- Added test case for the cookie time being set

Added test to assert that the .sig cookie is expired when 'signed: true'

Pull Request Pull Request #180: #172: Correctly expire cookies for nullified sessions

Run Details

8 of 8 relevant lines covered (100.0%)

100.5 hits per line

Jobs

ID	Job ID	Ran	Coverage
1	382.1	19 Aug 2019 03:05AM UTC	100.0	Travis Job 382.1
2	382.2	19 Aug 2019 03:05AM UTC	100.0	Travis Job 382.2
3	382.3	19 Aug 2019 03:05AM UTC	100.0	Travis Job 382.3
4	382.4	19 Aug 2019 03:05AM UTC	100.0	Travis Job 382.4

Source Files on build 382

Detailed source file information is not available for this build.

koajs / session / 382
100%
master: 100%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 382

koajs / session / 382 100% master: 100%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 382

koajs / session / 382
100%
master: 100%

README BADGES
x