3
100%
master: 100%

Ran 17 Jul 2019 12:16PM UTC

Files 32

Run time 1s

Badge

Embed ▾

Committed 17 Jul 2019 12:14PM UTC coverage: 100.0%. Remained the same

Job # 2.5.3

Build Type

push

travis-ci

Committed by

dmagliola

Commit Message

Avoid revalidating labelset keys on each metric observation

When declaring a metric, we declare what label keys will be used for it.
At that point, we validate that those are all valid keys (symbols,
match a given regex, etc).

Then, on each observation of the metric, we validate that the keys passed
in for the labels match the ones we were originally expecting, to make
sure all of those labels were set, but no others.

We were also, at that point, validating that the keys passed in are valid.
This validation is pretty slow, and it's redundant, since keys that aren't
valid won't match the expected ones anyway, so we can just compare just
that those match. This has quite a pronounced effect on performance.

Signed-off-by: Daniel Magliola <danielmagliola@gocardless.com>

Run Details

1413 of 1413 relevant lines covered (100.0%)

14.34 hits per line

prometheus / client_ruby / 448 / 3
100%
master: 100%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 448.3 (2.5.3)

prometheus / client_ruby / 448 / 3 100% master: 100%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 448.3 (2.5.3)

prometheus / client_ruby / 448 / 3
100%
master: 100%

README BADGES
x