448
100%
master: 100%

Ran 17 Jul 2019 12:16PM UTC

Jobs 4

Files 32

Run time 4min

Badge

Embed ▾

pending completion

Build # 448

Build Type

push

travis-ci

Committed by

dmagliola

Commit Message

Avoid revalidating labelset keys on each metric observation

When declaring a metric, we declare what label keys will be used for it.
At that point, we validate that those are all valid keys (symbols,
match a given regex, etc).

Then, on each observation of the metric, we validate that the keys passed
in for the labels match the ones we were originally expecting, to make
sure all of those labels were set, but no others.

We were also, at that point, validating that the keys passed in are valid.
This validation is pretty slow, and it's redundant, since keys that aren't
valid won't match the expected ones anyway, so we can just compare just
that those match. This has quite a pronounced effect on performance.

Signed-off-by: Daniel Magliola <danielmagliola@gocardless.com>

Run Details

1410 of 1410 relevant lines covered (100.0%)

42.47 hits per line

Jobs

ID	Job ID	Ran	Coverage
1	448.1 (2.3.8)	17 Jul 2019 12:16PM UTC	100.0	Travis Job 448.1
2	448.2 (2.4.5)	17 Jul 2019 12:16PM UTC	100.0	Travis Job 448.2
3	448.3 (2.5.3)	17 Jul 2019 12:16PM UTC	100.0	Travis Job 448.3
5	448.5 (jruby-9.1.5.0)	17 Jul 2019 12:20PM UTC	0.0	Travis Job 448.5

Source Files on build 448

Detailed source file information is not available for this build.

prometheus / client_ruby / 448
100%
master: 100%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 448

prometheus / client_ruby / 448 100% master: 100%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 448

prometheus / client_ruby / 448
100%
master: 100%

README BADGES
x