apache / bookkeeper / 511 / 1

72%

master: 72%

Build Type

push

jenkins

Committed by Enrico Olivelli

Commit Message

<a href="https://github.com/apache/bookkeeper/commit/<a class=hub.com/apache/bookkeeper/commit/1adc93f05954fdb06d7e8b548d606e281831924a">1adc93f05<a href="https://github.com/apache/bookkeeper/commit/1adc93f05954fdb06d7e8b548d606e281831924a">&quot;&gt;Issue #2103: Avoid stop of entry log compaction

### Motivation

As mentioned in #2103, if an exception occurs during compaction of a specific entry log, `GarbageCollectorThread` does not perform compaction of other entry logs until the bookie server is restarted. As a result, the number of entry logs continues to increase and eventually it will run out of disk space.

### Changes

The cause of the compaction stop is that the `compacting` flag remains true if `compactor.compact(entryLogMeta)` throws some exception.
https://github.com/apache/bookkeeper/blob/</a><a class="double-link" href="https://github.com/apache/bookkeeper/commit/<a class="double-link" href="https://github.com/apache/bookkeeper/commit/b2e099bbc7b13f13825fe78ab009ca132cb3a9ba">b2e099bbc</a>">b2e099bbc</a><a href="https://github.com/apache/bookkeeper/commit/1adc93f05954fdb06d7e8b548d606e281831924a">/bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/GarbageCollectorThread.java#L504-L519

Therefore, fixed `GarbageCollectorThread` so that it set the compaction flag to false even if compaction of a specific entry log fails.

Master Issue: #2103

Reviewers: Enrico Olivelli &lt;eolivelli@gmail.com&gt;, Sijie Guo &lt;sijie@apache.org>

This closes #2121 from massakam/entry-log-compaction, closes #2103

Run Details

27743 of 38727 relevant lines covered (71.64%)

0.72 hits per line