apache / bookkeeper / 510 / 1

72%

master: 72%

Build Type

push

jenkins

Committed by Enrico Olivelli

Commit Message

<a href="https://github.com/apache/bookkeeper/commit/<a class=hub.com/apache/bookkeeper/commit/<a class="double-link" href="https://git"><a class=hub.com/apache/bookkeeper/commit/<a class="double-link" href="https://git"><a class=hub.com/apache/bookkeeper/commit/<a class="double-link" href="https://git"><a class=hub.com/apache/bookkeeper/commit/1adc93f05954fdb06d7e8b548d606e281831924a">1adc93f05<a href="https://github.com/apache/bookkeeper/commit/1adc93f05954fdb06d7e8b548d606e281831924a">&quot;&gt;&amp;lt;a href=&amp;quot;https://github.com/apache/bookkeeper/commit/&lt;/a&gt;&lt;a class=&quot;double-link&quot; href=&quot;https://github.com/apache/bookkeeper/commit/&amp;lt;a class=&amp;quot;double-link&amp;quot; href=&amp;quot;https://git&quot;&gt;&amp;lt;a class=&lt;/a&gt;hub.com/apache/bookkeeper/commit/1adc93f05954fdb06d7e8b548d606e281831924a&quot;&gt;1adc93f05&lt;/a&gt;&lt;a href=&quot;https://github.com/apache/bookkeeper/commit/1adc93f05954fdb06d7e8b548d606e281831924a&quot;&gt;&amp;lt;a href=&amp;quot;https://github.com/apache/bookkeeper/commit/1adc93f05954fdb06d7e8b548d606e281831924a&amp;quot;&amp;gt;&amp;amp;quot;&amp;amp;gt;Issue #2103: Avoid stop of entry log compaction

### Motivation

As mentioned in #2103, if an exception occurs during compaction of a specific entry log, `GarbageCollectorThread` does not perform compaction of other entry logs until the bookie server is restarted. As a result, the number of entry logs continues to increase and eventually it will run out of disk space.

### Changes

The cause of the compaction stop is that the `compacting` flag remains true if `compactor.compact(entryLogMeta)` throws some exception.
https://github.c</a>om/apache/bookkeeper/blob/&lt;/a&gt;&lt;a class=&quot;double-link&quot; href=&quot;https://github.com/apache/bookkeeper/commit/&lt;a class=&quot;double-link&quot; href=&quot;https://github.com/apache/bookkeeper/commit/<a class="double-link" href="https://github.com/apache/bookkeeper/commit/b2e099bbc7b13f13825fe78ab009ca132cb3a9ba">b2e099bbc</a>&quot;&gt;b2e099bbc&lt;/a&gt;&quot;&gt;b2e099bbc&lt;/a&gt;&lt;a href=&quot;https://github.com/apache/bookkeeper/commit/1adc93f05954fdb06d7e8b548d606e281831924a&quot;&gt;/bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/GarbageCollectorThread.java#L504-L519

Therefore, fixed `GarbageCollectorThread` so that it set the compaction flag to false even if compaction of a specific entry log fails.

Master Issue: #2103

Reviewers: Enrico Olivelli &amp;lt;eolivelli@gmail.com&gt;, Sijie Guo &lt;sijie@apache.org>

This closes #2121 ... (continued)

Run Details

27736 of 38727 relevant lines covered (71.62%)

0.72 hits per line