1
89%
master: 89%

Ran 19 Jun 2019 05:06PM UTC

Files 261

Run time 12min

Badge

Embed ▾

Committed 19 Jun 2019 04:51PM UTC coverage: 87.261% (+0.006%) from 87.255%

Job # 14422.1

Build Type

push

travis-ci

Committed by

web-flow

Commit Message

netty-shaded: Use compile instead of runtime dependency in pom (#5901)

Maven does not include transitive runtime dependencies in the
compile-time classpath (testing shows Gradle 4 does; docs say
Gradle 5 doesn't). So if a user references the shaded
NettyServerBuilder without also depending on grpc-core directly,
compilation will fail because AbstractServerImplBuilder couldn't
be found.

This isn't technically a problem, since we're not wanting to encourage
users to reference the shaded classes directly. But some users will
certainly reference the classes anyway and the error is pretty confusing
while also being trivially worked around. In other words: it justs
wastes people's time and benefits nobody.

Fixes #5881

Run Details

15042 of 17238 relevant lines covered (87.26%)

0.87 hits per line

grpc / grpc-java / 14422 / 1
89%
master: 89%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 14422.1

grpc / grpc-java / 14422 / 1 89% master: 89%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 14422.1

grpc / grpc-java / 14422 / 1
89%
master: 89%

README BADGES
x