1
89%
master: 89%

Ran 18 Jun 2019 04:52PM UTC

Files 261

Run time 14s

Badge

Embed ▾

Committed 18 Jun 2019 04:33PM UTC coverage: 87.264% (+0.003%) from 87.261%

Job # 14401.1

Build Type

push

travis-ci

Committed by

web-flow

Commit Message

netty,alts: fire initial protocol negotiation event in WBAEH

This change is needed after trying to use the new style protocol negotiators internally.  The problem is that some handlers fire the event in handlerAdded, which is too early.  The followup PNE is fired after handlerAdded, which breaks the composibility of the negotiators.

To fix this, this change modifies the negotiation flow.  Specifically:

* Negotiators should NEVER fire a negotiation from handlerAdded, instead they should wait until userEventTriggered
* Negotiators now do state checking on the PNE.  If it is set twice, it fails.  If it has not been received when doing the next stage of negotiation, it fails.
* WBAEH now fires the initial, default event.  This is the only handler that can fire it from handlerAdded

The tests updated are ones not using WBAEH (which they probably should).  This change ensures attributes aren't lost when doing negotiation.

Run Details

15040 of 17235 relevant lines covered (87.26%)

0.87 hits per line

grpc / grpc-java / 14401 / 1
89%
master: 89%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 14401.1

grpc / grpc-java / 14401 / 1 89% master: 89%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 14401.1

grpc / grpc-java / 14401 / 1
89%
master: 89%

README BADGES
x