1
89%
master: 89%

Ran 14 Jun 2019 11:59PM UTC

Files 261

Run time 12s

Badge

Embed ▾

Committed 14 Jun 2019 11:47PM UTC coverage: 87.176% (+0.006%) from 87.17%

Job # 14377.1

Build Type

push

travis-ci

Committed by

web-flow

Commit Message

services: fix HealthCheckingLoadBalancer.shutdown() (#5887)

The issue: HealthCheckingLoadBalancer.shutdown() calls
hcState.onSubchannelState(SHUTDOWN) which removes that hcState from
helper.hcStates. Therefore, if more than one Subchannels are present,
ConcurrentModificationException will be thrown.

This is an alternative approach from #5848 that was reverted in #5875. Thanks to #5883, HealthCheckingLoadBalancer.shutdown() no longer has to fake SHUTDOWN notifications, and can completely rely on Subchannels' real SHUTDOWN notifications for triggering the clean-up.

Run Details

14969 of 17171 relevant lines covered (87.18%)

0.87 hits per line

grpc / grpc-java / 14377 / 1
89%
master: 89%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 14377.1

grpc / grpc-java / 14377 / 1 89% master: 89%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 14377.1

grpc / grpc-java / 14377 / 1
89%
master: 89%

README BADGES
x