2
94%
master: 94%

Ran 02 Jun 2019 09:26PM UTC

Files 89

Run time 4s

Badge

Embed ▾

Committed 02 Jun 2019 09:22PM UTC coverage: 94.542%. Remained the same

Job # TOXENV=py36

Build Type

push

travis-ci

Committed by

web-flow

Commit Message

Allow proper caching with `If-Modified-Since`. (#395)

There is a subtle difference between `no-store` and `no-cache`.

`no-store`: Never return from cache, always request new. (Especially problematic for images, which are always re-loaded.) **This is what we currently have**.

`no-cache`: Don't return from cache by default, but first re-validate with the server, in our case using the `If-Modified-Since` header, which browsers use automatically, as eve includes `Last-Modified` headers in all responses. **This is what we actually want.**

Thus, with this small change, the api should cache in the way we want. Stale results from cache will never be returned without a request, and data is only transmitted if anything has changed.

More info: https://www.keycdn.com/blog/http-cache-headers

Note: Having both `no-cache` and `must-revalidate` doesn't actually do anything, as each on it's own would be enough for what we want, but for compatibility its probably best to keep both.

Closes #389

Run Details

4036 of 4269 relevant lines covered (94.54%)

0.95 hits per line

amiv-eth / amivapi / 718 / 2
94%
master: 94%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 718.2 (TOXENV=py36)

amiv-eth / amivapi / 718 / 2 94% master: 94%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 718.2 (TOXENV=py36)

amiv-eth / amivapi / 718 / 2
94%
master: 94%

README BADGES
x