718
94%

Ran 02 Jun 2019 09:24PM UTC

Jobs 3

Files 89

Run time 2min

Badge

Embed ▾

pending completion

Build # 718

Build Type

push

travis-ci

Committed by

web-flow

Commit Message

Allow proper caching with `If-Modified-Since`. (#395)

There is a subtle difference between `no-store` and `no-cache`.

`no-store`: Never return from cache, always request new. (Especially problematic for images, which are always re-loaded.) **This is what we currently have**.

`no-cache`: Don't return from cache by default, but first re-validate with the server, in our case using the `If-Modified-Since` header, which browsers use automatically, as eve includes `Last-Modified` headers in all responses. **This is what we actually want.**

Thus, with this small change, the api should cache in the way we want. Stale results from cache will never be returned without a request, and data is only transmitted if anything has changed.

More info: https://www.keycdn.com/blog/http-cache-headers

Note: Having both `no-cache` and `must-revalidate` doesn't actually do anything, as each on it's own would be enough for what we want, but for compatibility its probably best to keep both.

Closes #389

Run Details

4036 of 4269 relevant lines covered (94.54%)

1.89 hits per line

Jobs

ID	Job ID	Ran	Coverage
1	718.1 (TOXENV=py35)	02 Jun 2019 09:26PM UTC	94.73	Travis Job 718.1
2	718.2 (TOXENV=py36)	02 Jun 2019 09:26PM UTC	94.54	Travis Job 718.2
3	718.3 (TOXENV=flake8)	02 Jun 2019 09:24PM UTC		Travis Job 718.3

Source Files on build 718

Detailed source file information is not available for this build.

amiv-eth / amivapi / 718
94%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 718

amiv-eth / amivapi / 718 94%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 718

amiv-eth / amivapi / 718
94%

README BADGES
x