1
89%
master: 89%

Ran 17 May 2019 11:51PM UTC

Files 268

Run time 15s

Badge

Embed ▾

Committed 17 May 2019 11:37PM UTC coverage: 86.941% (+0.05%) from 86.896%

Job # 14056.1

Build Type

push

travis-ci

Committed by

web-flow

Commit Message

api: pass Subchannel state updates to SubchannelStateListener rather than LoadBalancer (take 2) (#5722)

This is a revised version of #5503 (62b03fd), which was rolled back in f8d0868. The newer version passes SubchannelStateListener to Subchannel.start() instead of SubchannelCreationArgs, which allows us to remove the Subchannel argument from the listener, which works as a solution for #5676.

LoadBalancers that call the old createSubchannel() will get start() implicitly called with a listener that passes updates to the deprecated LoadBalancer.handleSubchannelState(). Those who call the new createSubchannel() will have to call start() explicitly.

GRPCLB code is still using the old API, because it's a pain to migrate the SubchannelPool to the new API.  Since CachedSubchannelHelper is on the way, it's easier to switch to it when it's ready. Keeping
GRPCLB with the old API would also confirm the backward compatibility.

Coverage Stats

14939 of 17183 relevant lines covered (86.94%)

0.87 hits per line

grpc / grpc-java / 14056 / 1
89%
master: 89%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 14056.1

grpc / grpc-java / 14056 / 1 89% master: 89%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 14056.1

grpc / grpc-java / 14056 / 1
89%
master: 89%

README BADGES
x