6
74%
develop: 74%

Ran 15 May 2019 09:52AM UTC

Files 387

Run time 22s

Badge

Embed ▾

Committed 15 May 2019 09:22AM UTC coverage: 66.401% (-0.06%) from 66.46%

Job # TEST_AIIDA_BACKEND=django TEST_TYPE="tests"

Build Type

push

travis-ci

Committed by

web-flow

Commit Message

Capture `KeyboardInterrupt` in `Runner.run` and kill processes (#2744)

Currently, if a user runs a `Process` in a local interpreter and then
interrupts the interpreter the process will be lost. However, the node
will reflect the last active state. This can be confusing to new users,
who will still for example see a "process" in the `Waiting` state.

To prevent this situation, the `Runner._run` method is modified and
attaches listeners to the `SIGINT` and `SIGTERM` signals that when
emitted will trigger a clean function that will log the interrupt and
call `process.kill` on the process that is currently in the scope.
This should ensure that if a user runs a process in a local interpreter
and interrupts it, the process will be properly killed, which will cause
the node to properly reflect what has happened.

The current solution works for a single process being run, but has
issues for nested processes. Sometimes only the current process is
killed and the others in the chain are unaffected before the interpreter
shuts down.

Run Details

21781 of 32802 relevant lines covered (66.4%)

0.66 hits per line

aiidateam / aiida_core / 6116 / 6
74%
develop: 74%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 6116.6 (TEST_AIIDA_BACKEND=django TEST_TYPE="tests")

aiidateam / aiida_core / 6116 / 6 74% develop: 74%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 6116.6 (TEST_AIIDA_BACKEND=django TEST_TYPE="tests")

aiidateam / aiida_core / 6116 / 6
74%
develop: 74%

README BADGES
x