6116
74%

Ran 15 May 2019 09:48AM UTC

Jobs 4

Files 387

Run time 5min

Badge

Embed ▾

pending completion

Build # 6116

Build Type

push

travis-ci

Committed by

web-flow

Commit Message

Capture `KeyboardInterrupt` in `Runner.run` and kill processes (#2744)

Currently, if a user runs a `Process` in a local interpreter and then
interrupts the interpreter the process will be lost. However, the node
will reflect the last active state. This can be confusing to new users,
who will still for example see a "process" in the `Waiting` state.

To prevent this situation, the `Runner._run` method is modified and
attaches listeners to the `SIGINT` and `SIGTERM` signals that when
emitted will trigger a clean function that will log the interrupt and
call `process.kill` on the process that is currently in the scope.
This should ensure that if a user runs a process in a local interpreter
and interrupts it, the process will be properly killed, which will cause
the node to properly reflect what has happened.

The current solution works for a single process being run, but has
issues for nested processes. Sometimes only the current process is
killed and the others in the chain are unaffected before the interpreter
shuts down.

Run Details

23849 of 32802 relevant lines covered (72.71%)

2.71 hits per line

Jobs

ID	Job ID	Ran	Coverage
5	6116.5 (TEST_AIIDA_BACKEND=django TEST_TYPE="tests")	15 May 2019 09:48AM UTC	66.49	Travis Job 6116.5
6	6116.6 (TEST_AIIDA_BACKEND=django TEST_TYPE="tests")	15 May 2019 09:52AM UTC	66.4	Travis Job 6116.6
7	6116.7 (TEST_AIIDA_BACKEND=sqlalchemy TEST_TYPE="tests")	15 May 2019 09:52AM UTC	69.17	Travis Job 6116.7
8	6116.8 (TEST_AIIDA_BACKEND=sqlalchemy TEST_TYPE="tests")	15 May 2019 09:52AM UTC	69.11	Travis Job 6116.8

Source Files on build 6116

Detailed source file information is not available for this build.

aiidateam / aiida_core / 6116
74%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 6116

aiidateam / aiida_core / 6116 74%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 6116

aiidateam / aiida_core / 6116
74%

README BADGES
x