32
95%
master: 90%

Ran 29 Apr 2019 05:19PM UTC

Files 18

Run time 1s

Badge

Embed ▾

Committed 29 Apr 2019 04:53PM UTC coverage: 83.389% (-0.2%) from 83.559%

Job # ruby-head, CHILDPROCESS_POSIX_SPAWN=true CHILDPROCESS_UNSET=should-be-unset

Build Type

Pull #149

travis-ci

Committed by

web-flow

Commit Message

Rewrite unix fork reopen to be compatible with ruby 2.6

On ruby 2.6 the original code would fail specs:

lib/childprocess/unix/fork_exec_process.rb:32:in `reopen': exclusive
access mode is not supported (ArgumentError)

The documentation for reopen shows that it has two ways to call it:

  reopen(other_IO) -> ios
  reopen(path, mode [,opt]) -> ios

With ruby 2.4 and 2.5 calling reopen with a path and no mode seems to
work fine, but with ruby 2.6 this triggers the spec failure.

This commit splits the calls based on stdout/stderr availability so
that both types of reopen calls can get the required parameters. This
fixes the 2.6 specs while being backward compatible with ruby 2.4 and
2.5.

Pull Request Pull Request #149: Rewrite unix fork reopen to be compatible with ruby 2.6

Coverage Stats

743 of 891 relevant lines covered (83.39%)

36.5 hits per line

enkessler / childprocess / 439 / 32
95%
master: 90%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 439.32 (ruby-head, CHILDPROCESS_POSIX_SPAWN=true CHILDPROCESS_UNSET=should-be-unset)

enkessler / childprocess / 439 / 32 95% master: 90%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 439.32 (ruby-head, CHILDPROCESS_POSIX_SPAWN=true CHILDPROCESS_UNSET=should-be-unset)

enkessler / childprocess / 439 / 32
95%
master: 90%

README BADGES
x