439
95%
master: 90%

Ran 29 Apr 2019 04:54PM UTC

Jobs 28

Files 21

Run time 33min

Badge

Embed ▾

pending completion

Build # 439

Build Type

Pull #149

travis-ci

Committed by

web-flow

Commit Message

Rewrite unix fork reopen to be compatible with ruby 2.6

On ruby 2.6 the original code would fail specs:

lib/childprocess/unix/fork_exec_process.rb:32:in `reopen': exclusive
access mode is not supported (ArgumentError)

The documentation for reopen shows that it has two ways to call it:

  reopen(other_IO) -> ios
  reopen(path, mode [,opt]) -> ios

With ruby 2.4 and 2.5 calling reopen with a path and no mode seems to
work fine, but with ruby 2.6 this triggers the spec failure.

This commit splits the calls based on stdout/stderr availability so
that both types of reopen calls can get the required parameters. This
fixes the 2.6 specs while being backward compatible with ruby 2.4 and
2.5.

Pull Request Pull Request #149: Rewrite unix fork reopen to be compatible with ruby 2.6

Coverage Stats

606 of 640 relevant lines covered (94.69%)

567.35 hits per line

Jobs

ID	Job ID	Ran	Coverage
1	439.1 (2.0.0, CHILDPROCESS_POSIX_SPAWN=true CHILDPROCESS_UNSET=should-be-unset)	29 Apr 2019 04:55PM UTC	83.74	Travis Job 439.1
2	439.2 (2.1, CHILDPROCESS_POSIX_SPAWN=true CHILDPROCESS_UNSET=should-be-unset)	29 Apr 2019 04:55PM UTC	83.63	Travis Job 439.2
3	439.3 (2.2, CHILDPROCESS_POSIX_SPAWN=true CHILDPROCESS_UNSET=should-be-unset)	29 Apr 2019 04:54PM UTC	83.87	Travis Job 439.3
4	439.4 (2.3, CHILDPROCESS_POSIX_SPAWN=true CHILDPROCESS_UNSET=should-be-unset)	29 Apr 2019 04:55PM UTC	83.31	Travis Job 439.4
5	439.5 (2.4, CHILDPROCESS_POSIX_SPAWN=true CHILDPROCESS_UNSET=should-be-unset)	29 Apr 2019 04:55PM UTC	83.76	Travis Job 439.5
6	439.6 (2.5, CHILDPROCESS_POSIX_SPAWN=true CHILDPROCESS_UNSET=should-be-unset)	29 Apr 2019 04:56PM UTC	83.65	Travis Job 439.6
7	439.7 (2.0.0, CHILDPROCESS_POSIX_SPAWN=false CHILDPROCESS_UNSET=should-be-unset)	29 Apr 2019 04:57PM UTC	88.13	Travis Job 439.7
8	439.8 (2.1, CHILDPROCESS_POSIX_SPAWN=false CHILDPROCESS_UNSET=should-be-unset)	29 Apr 2019 04:57PM UTC	87.99	Travis Job 439.8
9	439.9 (2.2, CHILDPROCESS_POSIX_SPAWN=false CHILDPROCESS_UNSET=should-be-unset)	29 Apr 2019 04:59PM UTC	88.13	Travis Job 439.9
10	439.10 (2.3, CHILDPROCESS_POSIX_SPAWN=false CHILDPROCESS_UNSET=should-be-unset)	29 Apr 2019 04:57PM UTC	87.99	Travis Job 439.10
11	439.11 (2.4, CHILDPROCESS_POSIX_SPAWN=false CHILDPROCESS_UNSET=should-be-unset)	29 Apr 2019 04:58PM UTC	87.99	Travis Job 439.11
12	439.12 (2.5, CHILDPROCESS_POSIX_SPAWN=false CHILDPROCESS_UNSET=should-be-unset)	29 Apr 2019 04:58PM UTC	88.13	Travis Job 439.12
13	439.13 (2.1, CHILDPROCESS_POSIX_SPAWN=true CHILDPROCESS_UNSET=should-be-unset)	29 Apr 2019 05:00PM UTC	83.61	Travis Job 439.13
14	439.14 (2.2, CHILDPROCESS_POSIX_SPAWN=true CHILDPROCESS_UNSET=should-be-unset)	29 Apr 2019 05:00PM UTC	83.52	Travis Job 439.14
15	439.15 (2.3, CHILDPROCESS_POSIX_SPAWN=true CHILDPROCESS_UNSET=should-be-unset)	29 Apr 2019 05:04PM UTC	83.96	Travis Job 439.15
16	439.16 (2.4, CHILDPROCESS_POSIX_SPAWN=true CHILDPROCESS_UNSET=should-be-unset)	29 Apr 2019 05:04PM UTC	83.96	Travis Job 439.16
17	439.17 (2.5, CHILDPROCESS_POSIX_SPAWN=true CHILDPROCESS_UNSET=should-be-unset)	29 Apr 2019 05:07PM UTC	83.96	Travis Job 439.17
18	439.18 (2.1, CHILDPROCESS_POSIX_SPAWN=false CHILDPROCESS_UNSET=should-be-unset)	29 Apr 2019 05:06PM UTC	87.99	Travis Job 439.18
19	439.19 (2.2, CHILDPROCESS_POSIX_SPAWN=false CHILDPROCESS_UNSET=should-be-unset)	29 Apr 2019 05:09PM UTC	87.73	Travis Job 439.19
20	439.20 (2.3, CHILDPROCESS_POSIX_SPAWN=false CHILDPROCESS_UNSET=should-be-unset)	29 Apr 2019 05:10PM UTC	87.86	Travis Job 439.20
21	439.21 (2.4, CHILDPROCESS_POSIX_SPAWN=false CHILDPROCESS_UNSET=should-be-unset)	29 Apr 2019 05:12PM UTC	87.99	Travis Job 439.21
22	439.22 (2.5, CHILDPROCESS_POSIX_SPAWN=false CHILDPROCESS_UNSET=should-be-unset)	29 Apr 2019 05:13PM UTC	87.73	Travis Job 439.22
25	439.25 (rbx-3, CHILDPROCESS_POSIX_SPAWN=true CHILDPROCESS_UNSET=should-be-unset)	29 Apr 2019 05:08PM UTC	96.37	Travis Job 439.25
26	439.26 (ruby-head, CHILDPROCESS_POSIX_SPAWN=true CHILDPROCESS_UNSET=should-be-unset)	29 Apr 2019 05:06PM UTC	83.18	Travis Job 439.26
28	439.28 (rbx-3, CHILDPROCESS_POSIX_SPAWN=false CHILDPROCESS_UNSET=should-be-unset)	29 Apr 2019 05:14PM UTC	94.38	Travis Job 439.28
29	439.29 (ruby-head, CHILDPROCESS_POSIX_SPAWN=false CHILDPROCESS_UNSET=should-be-unset)	29 Apr 2019 05:11PM UTC	88.32	Travis Job 439.29
32	439.32 (ruby-head, CHILDPROCESS_POSIX_SPAWN=true CHILDPROCESS_UNSET=should-be-unset)	29 Apr 2019 05:19PM UTC	83.39	Travis Job 439.32
35	439.35 (ruby-head, CHILDPROCESS_POSIX_SPAWN=false CHILDPROCESS_UNSET=should-be-unset)	29 Apr 2019 05:28PM UTC	88.19	Travis Job 439.35

Source Files on build 439

Detailed source file information is not available for this build.

enkessler / childprocess / 439
95%
master: 90%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 439

enkessler / childprocess / 439 95% master: 90%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 439

enkessler / childprocess / 439
95%
master: 90%

README BADGES
x