Ran
|
Files
314
|
Run time
22s
|
Badge
Embed ▾
README BADGES
|
push
travis-ci
Make sure <?xml starts at the beginning of the file when creating an empty xml report - Make sure `<?xml` starts at the beginning of the file when creating an empty xml report. - Create the empty report under a different name to avoid confusing it with real ivy output. - This change also raises an exception when the ivy report .xml file is not found. I'm not sure why it wouldn't be there, and the creation of ivy_jar_products now depends on it. Testing Done: CI is green at https://travis-ci.org/pantsbuild/pants/builds/53264069 I don't think this code ever gets exercised, I forced it in a pdb session by setting a break point then moving the report aside. ``` ls -l /Users/zundel/.ivy2/pants/internal-<a class=hub.com/pantsbuild/pants/commit/<a class="double-link" href="https://git"><a class=hub.com/pantsbuild/pants/commit/f8ecb12181375ea82eee7fdf81233ebfaed4d60f">f8ecb1218-default* -rw-r--r-- 1 zundel zundel 409 Mar 5 17:17 /Users/zundel/.ivy2/pants/internal-f8ecb12181375ea82eee7fdf81233ebfaed4d60f-default-empty.xml -rw-r--r-- 1 zundel zundel 24974 Mar 5 17:14 /Users/zundel/.ivy2/pants/internal-f8ecb12181375ea82eee7fdf81233ebfaed4d60f-default.xml.old ``` while running ./pants idea examples/src/java:: --resove-ivy-open Before this change, if you do try to parse the file created by this function you get: ``` FAILURE Exception message: XML or text declaration not at start of entity: line 2, column 8 ``` Bugs closed: 1196 Reviewed at https://rbcommons.com/s/twitter/r/1856/
12481 of 18138 relevant lines covered (68.81%)
0.69 hits per line
Coverage | ∆ | File | Lines | Relevant | Covered | Missed | Hits/Line |
---|