3
79%
master: 79%

Ran 24 Apr 2019 10:03PM UTC

Files 100

Run time 5s

Badge

Embed ▾

Committed 24 Apr 2019 09:50PM UTC coverage: 78.1% (+0.1%) from 77.964%

Job # PYVER=3.7

Build Type

push

travis-ci

Committed by

web-flow

Commit Message

Fix invalid component handling (#431)

Previously, if one added an invalid parameter, rule etc. that generated
an exception in `__init__`, (e.g. a validation error), the component
was still added to the model. In interactive mode, this is annoying, as
the model has to be re-instantiated. Example:

    Model()
    Parameter('a', 'invalid_value')  # raises ValueError
    assert len(model.parameters) == 0  # fixed in this PR
    Parameter('a', 1.0)  # should succeed

This PR fixes this situation by adding the Component to the Model
(by calling `Component.__init__()`) last instead of first.

Run Details

7389 of 9461 relevant lines covered (78.1%)

0.78 hits per line

LoLab-VU / pysb / 910 / 3
79%
master: 79%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 910.3 (PYVER=3.7)

LoLab-VU / pysb / 910 / 3 79% master: 79%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 910.3 (PYVER=3.7)

LoLab-VU / pysb / 910 / 3
79%
master: 79%

README BADGES
x