910
79%

Ran 24 Apr 2019 10:03PM UTC

Jobs 3

Files 100

Run time 5min

Badge

Embed ▾

pending completion

Build # 910

Build Type

push

travis-ci

Committed by

web-flow

Commit Message

Fix invalid component handling (#431)

Previously, if one added an invalid parameter, rule etc. that generated
an exception in `__init__`, (e.g. a validation error), the component
was still added to the model. In interactive mode, this is annoying, as
the model has to be re-instantiated. Example:

    Model()
    Parameter('a', 'invalid_value')  # raises ValueError
    assert len(model.parameters) == 0  # fixed in this PR
    Parameter('a', 1.0)  # should succeed

This PR fixes this situation by adding the Component to the Model
(by calling `Component.__init__()`) last instead of first.

Run Details

7389 of 9461 relevant lines covered (78.1%)

2.35 hits per line

Jobs

ID	Job ID	Ran	Coverage
1	910.1 (PYVER=2.7)	24 Apr 2019 10:08PM UTC	78.5	Travis Job 910.1
2	910.2 (PYVER=3.6)	24 Apr 2019 10:04PM UTC	78.1	Travis Job 910.2
3	910.3 (PYVER=3.7)	24 Apr 2019 10:03PM UTC	78.1	Travis Job 910.3

Source Files on build 910

Detailed source file information is not available for this build.

LoLab-VU / pysb / 910
79%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 910

LoLab-VU / pysb / 910 79%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 910

LoLab-VU / pysb / 910
79%

README BADGES
x