• Home
  • Features
  • Pricing
  • Docs
  • Announcements
  • Sign In

nokia / danm / 278 / 1
44%
master: 44%

Build:
DEFAULT BRANCH: master
Ran 24 Apr 2019 12:46PM UTC
Files 10
Run time 0s
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst

24 Apr 2019 12:37PM UTC coverage: 34.344% (+0.1%) from 34.224%
TRAVIS_PIPELINE=docker

push

travis-ci

Levovar
Fixing iface deletion bug when netIds don't match

The project assumes that a DanmNet's NetworkID and ObjectMeta.Name parameters always match.
This is even outlined inthe schema descriptor.
However, recently we have introduced some changes which broke this assumption.
First, with the "default" feature, and then lately with the variable static delegate configuration.
The user might not even perceive it, but as a result of these changes interfaces weren't properly cleaned-up during CNI DEL invocations.
Instead of re-writing the whole codebase, we save the real name of the network as well into the interface's DanmEp, and use this parameter when we read the network descriptor during the deletion of the interface.
Meaning of NetworkID parameter left untouched in all the other places, but eventually, we need to revise when to sue which parameter.

Commit contains one more smal,, but important change: the first interface of a Pod will be always named "eth0" from now on.
This change will make it impossible for users to accidentally screw-up network naming, and thus kill their own Pod.

555 of 1616 relevant lines covered (34.34%)

9.09 hits per line

Source Files on job 278.1 (TRAVIS_PIPELINE=docker)
  • Tree
  • List 0
  • Changed 2
  • Source Changed 2
  • Coverage Changed 2
Coverage ∆ File Lines Relevant Covered Missed Hits/Line
  • Back to Build 123
  • Travis Job 278.1
  • 844b90c5 on github
  • Prev Job for TRAVIS_PIPELINE=docker on master (#270.1)
  • Next Job for TRAVIS_PIPELINE=docker on master (#280.1)
STATUS · Troubleshooting · Open an Issue · Sales · Support · CAREERS · ENTERPRISE · START FREE · SCHEDULE DEMO
ANNOUNCEMENTS · TWITTER · TOS & SLA · Supported CI Services · What's a CI service? · Automated Testing

© 2026 Coveralls, Inc