278
44%

Ran 24 Apr 2019 12:46PM UTC

Jobs 1

Files 10

Run time 2s

Badge

Embed ▾

Committed 24 Apr 2019 12:37PM UTC coverage: 34.344% (+0.1%) from 34.224%

Build # 278

Build Type

push

travis-ci

Committed by

Levovar

Commit Message

Fixing iface deletion bug when netIds don't match

The project assumes that a DanmNet's NetworkID and ObjectMeta.Name parameters always match.
This is even outlined inthe schema descriptor.
However, recently we have introduced some changes which broke this assumption.
First, with the "default" feature, and then lately with the variable static delegate configuration.
The user might not even perceive it, but as a result of these changes interfaces weren't properly cleaned-up during CNI DEL invocations.
Instead of re-writing the whole codebase, we save the real name of the network as well into the interface's DanmEp, and use this parameter when we read the network descriptor during the deletion of the interface.
Meaning of NetworkID parameter left untouched in all the other places, but eventually, we need to revise when to sue which parameter.

Commit contains one more smal,, but important change: the first interface of a Pod will be always named "eth0" from now on.
This change will make it impossible for users to accidentally screw-up network naming, and thus kill their own Pod.

Run Details

555 of 1616 relevant lines covered (34.34%)

9.09 hits per line

Jobs

ID	Job ID	Ran	Files	Coverage
1	278.1 (TRAVIS_PIPELINE=docker)	24 Apr 2019 12:46PM UTC	0	34.34	Travis Job 278.1

Source Files on build 278

Detailed source file information is not available for this build.

nokia / danm / 278
44%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 278

nokia / danm / 278 44%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 278

nokia / danm / 278
44%

README BADGES
x