1
89%
master: 89%

Ran 18 Mar 2019 07:51PM UTC

Files 260

Run time 13s

Badge

Embed ▾

Committed 18 Mar 2019 07:38PM UTC coverage: 87.101% (-0.04%) from 87.142%

Job # 13294.1

Build Type

push

travis-ci

Committed by

carl-mastrangelo

Commit Message

netty: default grace time for RPCs can leak memory

Using Long.MAX_VALUE as the delay for Netty's NioEventLoop#schedule can
cause (long) deadlines for scheduled tasks to wrap into negative values,
which is unspecified behavior. Recent versions of netty are guarding
against overflows, but not all versions of grpc-java are using a recent
enough netty.

When connections are gracefully closed, Netty's Http2ConnectionHandler
sets up a timeout task forcing resources to be freed after a grace
period. When their deadlines wrap into negative values, a race was
observed in production systems (with grpc-java <= 1.12.1) causing Netty
to never properly release buffers associated with active streams in the
connection being (gracefully) closed.

Coverage Stats

14282 of 16397 relevant lines covered (87.1%)

0.87 hits per line

grpc / grpc-java / 13294 / 1
89%
master: 89%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 13294.1

grpc / grpc-java / 13294 / 1 89% master: 89%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 13294.1

grpc / grpc-java / 13294 / 1
89%
master: 89%

README BADGES
x