1
89%
master: 89%

Ran 02 Mar 2019 03:16AM UTC

Files 258

Run time 1min

Badge

Embed ▾

Committed 02 Mar 2019 03:05AM UTC coverage: 87.07% (+0.007%) from 87.063%

Job # 13110.1

Build Type

push

travis-ci

Committed by

web-flow

Commit Message

core: refactor load-balancing config handling (#5397)

The LoadBalancingConfig message, which looks like
```json
{
  "policy_name" : {
    "config_key1" : "config_value1",
    "config_key2" : "config_value2"
   }
}
```
appears multiple times. It gets super tedious and confusing to handle, because both the whole config and the value (in the above example is `{ "config_key1" : "config_value1" }`) are just `Map<String, Object>`, and each user needs to do the following validation:
 1. The whole config must have exactly one key
 2. The value must be a map

Here I define `LbConfig` that holds the policy name and the config value, and a method in `ServiceConfigUtil` that converts the parsed JSON format into `LbConfig`.

There is also multiple cases where you need to handle a list of configs (top-level balancing policy, child and fallback policies in xds, grpclb child policies). I also made another helper method in `ServiceConfigUtil` to convert them into `List<LbConfig>`.

Found and fixed a bug in the xds code, where the top-level balancer should pass the config value (excluding the policy name), not the whole config to the child balancers. Search for "supported_1_option" in the diff to see it in the tests.

Coverage Stats

14141 of 16241 relevant lines covered (87.07%)

0.87 hits per line

grpc / grpc-java / 13110 / 1
89%
master: 89%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 13110.1

grpc / grpc-java / 13110 / 1 89% master: 89%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 13110.1

grpc / grpc-java / 13110 / 1
89%
master: 89%

README BADGES
x