12
75%
develop: 75%

Ran 28 Feb 2019 11:17PM UTC

Files 205

Run time 54s

Badge

Embed ▾

Committed 28 Feb 2019 09:43PM UTC coverage: 12.972% (-0.2%) from 13.143%

Job # TESTING_PROFILE=integration-tests

Build Type

push

travis-ci

Committed by

web-flow

Commit Message

Create a new version of a hosted workflow with Zip (#2148)


#1768

Allows a user to submit a zip file to add a new version to a hosted workflow. The zip file needs
to contain a .dockstore.yml in its root directory that describes the contents of the zip. See the DockstoreYaml.java class for expected fields.

I was initially going to do by submitting an application/octet-stream, but Swagger 2 codegen does not generate correct code for client libraries. See https://swagger.io/docs/specification/2-0/file-upload/.

Making it a multipart/form-data allows users to hit the UI from the Swagger UI.

The code ZipSourceFileHelper.java guards against "zip bomb" attacks. Unfortunately we can only see the size of the uncompressed entries in a zip by writing to a file -- reading from the payload directly in memory doesn't reliably give the sizes.

Todos

Should support a workflowVersion value in .dockstoreYaml, which will tag the revision accordingly. The code currently makes assumptions about the name field always being a number. See AbstractHostedEntryResourceName.calculateNextVersionName.

UI does not show .dockstore.yml.

DockstoreYaml.java is just a beginning and not really generic enough yet.

Run Details

1841 of 14192 relevant lines covered (12.97%)

0.25 hits per line

ga4gh / dockstore / 7487 / 12
75%
develop: 75%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 7487.12 (TESTING_PROFILE=integration-tests)

ga4gh / dockstore / 7487 / 12 75% develop: 75%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 7487.12 (TESTING_PROFILE=integration-tests)

ga4gh / dockstore / 7487 / 12
75%
develop: 75%

README BADGES
x