• Home
  • Features
  • Pricing
  • Docs
  • Announcements
  • Sign In

ga4gh / dockstore / 7487
75%

Build:
DEFAULT BRANCH: develop
Ran 28 Feb 2019 10:53PM UTC
Jobs 5
Files 207
Run time 25min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst

pending completion
7487

push

travis-ci

web-flow
Create a new version of a hosted workflow with Zip (#2148)


#1768

Allows a user to submit a zip file to add a new version to a hosted workflow. The zip file needs
to contain a .dockstore.yml in its root directory that describes the contents of the zip. See the DockstoreYaml.java class for expected fields.

I was initially going to do by submitting an application/octet-stream, but Swagger 2 codegen does not generate correct code for client libraries. See https://swagger.io/docs/specification/2-0/file-upload/.

Making it a multipart/form-data allows users to hit the UI from the Swagger UI.

The code ZipSourceFileHelper.java guards against "zip bomb" attacks. Unfortunately we can only see the size of the uncompressed entries in a zip by writing to a file -- reading from the payload directly in memory doesn't reliably give the sizes.

Todos

Should support a workflowVersion value in .dockstoreYaml, which will tag the revision accordingly. The code currently makes assumptions about the name field always being a number. See AbstractHostedEntryResourceName.calculateNextVersionName.

UI does not show .dockstore.yml.

DockstoreYaml.java is just a beginning and not really generic enough yet.

11075 of 14332 relevant lines covered (77.27%)

1.83 hits per line

Jobs
ID Job ID Ran Files Coverage
11 7487.11 (TESTING_PROFILE=unit-tests) 28 Feb 2019 10:53PM UTC 0
12.06
Travis Job 7487.11
12 7487.12 (TESTING_PROFILE=integration-tests) 28 Feb 2019 11:17PM UTC 0
12.97
Travis Job 7487.12
13 7487.13 (TESTING_PROFILE=tool-integration-tests) 28 Feb 2019 11:12PM UTC 0
42.72
Travis Job 7487.13
14 7487.14 (TESTING_PROFILE=workflow-integration-tests) 28 Feb 2019 11:18PM UTC 0
42.9
Travis Job 7487.14
15 7487.15 (TESTING_PROFILE=other-integration-tests) 28 Feb 2019 11:17PM UTC 0
47.79
Travis Job 7487.15
Source Files on build 7487
Detailed source file information is not available for this build.
  • Back to Repo
  • Travis Build #7487
  • 137f86c2 on github
  • Prev Build on develop (#7482)
  • Next Build on develop (#7488)
STATUS · Troubleshooting · Open an Issue · Sales · Support · CAREERS · ENTERPRISE · START FREE · SCHEDULE DEMO
ANNOUNCEMENTS · TWITTER · TOS & SLA · Supported CI Services · What's a CI service? · Automated Testing

© 2026 Coveralls, Inc