4
94%
master: 97%

Ran 11 Feb 2019 07:20PM UTC

Files 83

Run time 27min

Badge

Embed ▾

Committed 11 Feb 2019 07:18PM UTC coverage: 94.344% (-0.03%) from 94.369%

Job # 2.4

Build Type

Pull #743

travis-ci

Committed by

web-flow

Commit Message

Remove attempt to nicen `UploadIO` in logs

In #741 I tried to do something too clever by replacing instances of
`Faraday::UploadIO` found in parameters with a human-readable string to
improve `STRIPE_LOG` logging output.

I thought I'd tested it at the time, but apparently not (or not well
enough), and this change caused the regression detailed in #742.

My findings about how Faraday encodes multipart were apparently wrong
and it does use these parameters, so here we remove the step where we
try to nicen them for logging. The logs look a little worse, but it's
not that big of a deal.

I've tested this patch against the API and confirmed that it addresses
the problem.

Fixes #742.

Pull Request Pull Request #743: Remove attempt to nicen `UploadIO` in logs

Run Details

1668 of 1768 relevant lines covered (94.34%)

643.12 hits per line

stripe / stripe-ruby / 2924 / 4
94%
master: 97%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 2924.4 (2.4)

stripe / stripe-ruby / 2924 / 4 94% master: 97%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 2924.4 (2.4)

stripe / stripe-ruby / 2924 / 4
94%
master: 97%

README BADGES
x