• Home
  • Features
  • Pricing
  • Docs
  • Announcements
  • Sign In

stripe / stripe-ruby / 2924
94%
master: 97%

Build:
Build:
LAST BUILD BRANCH: HEAD
DEFAULT BRANCH: master
Ran 11 Feb 2019 07:19PM UTC
Jobs 6
Files 83
Run time 68min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst

pending completion
2924

Pull #743

travis-ci

web-flow
Remove attempt to nicen `UploadIO` in logs

In #741 I tried to do something too clever by replacing instances of
`Faraday::UploadIO` found in parameters with a human-readable string to
improve `STRIPE_LOG` logging output.

I thought I'd tested it at the time, but apparently not (or not well
enough), and this change caused the regression detailed in #742.

My findings about how Faraday encodes multipart were apparently wrong
and it does use these parameters, so here we remove the step where we
try to nicen them for logging. The logs look a little worse, but it's
not that big of a deal.

I've tested this patch against the API and confirmed that it addresses
the problem.

Fixes #742.
Pull Request #743: Remove attempt to nicen `UploadIO` in logs

1 of 1 new or added line in 1 file covered. (100.0%)

1636 of 1734 relevant lines covered (94.35%)

3226.54 hits per line

Jobs
ID Job ID Ran Files Coverage
1 2924.1 (2.1) 11 Feb 2019 07:20PM UTC 0
94.33
Travis Job 2924.1
2 2924.2 (2.2) 11 Feb 2019 07:20PM UTC 0
94.34
Travis Job 2924.2
3 2924.3 (2.3) 11 Feb 2019 07:19PM UTC 0
94.34
Travis Job 2924.3
4 2924.4 (2.4) 11 Feb 2019 07:20PM UTC 0
94.34
Travis Job 2924.4
5 2924.5 (2.5) 11 Feb 2019 07:20PM UTC 0
94.34
Travis Job 2924.5
6 2924.6 (jruby-9.0.5.0) 11 Feb 2019 07:22PM UTC 0
0.0
Travis Job 2924.6
Source Files on build 2924
Detailed source file information is not available for this build.
  • Back to Repo
  • Travis Build #2924
  • Pull Request #743
  • PR Base - master (#2921)
STATUS · Troubleshooting · Open an Issue · Sales · Support · CAREERS · ENTERPRISE · START FREE · SCHEDULE DEMO
ANNOUNCEMENTS · TWITTER · TOS & SLA · Supported CI Services · What's a CI service? · Automated Testing

© 2026 Coveralls, Inc