• Home
  • Features
  • Pricing
  • Docs
  • Announcements
  • Sign In

gryffon / ringteki / 5391 / 1
81%
develop: 38%

Build:
Build:
LAST BUILD BRANCH: master
DEFAULT BRANCH: develop
Ran 02 Feb 2019 12:34PM UTC
Files 766
Run time 39s
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst

02 Feb 2019 12:27PM UTC coverage: 80.461% (-0.1%) from 80.566%
CXX=g++-4.9

push

travis-ci

web-flow
Refactor Ability Resolver (#2827)

Previously, the ability resolver was a bit of a mish-mash of custom built events and event windows. Due to recent rulings, we have more clarity about how the playing cards/initating abilities process works. This means that the ability resolver now works as follows (which I think is much closer to the way the game rules mandate):

Step 1 & 2 happen before an ability is clicked
After the card is clicked, the ability resolver is added to the pipeline
it snapshots the ability's source
it raises an onCardAbilityInitiated event (any interrupts to ability initiation trigger here)
this adds step 3, 4, 5 and 6 to the pipeline
step 6 raises an onInitiateAbilityEffects event, which checks for cancels
the window for reactions to onCardAbilityInitiated happen next
finally the handler is executed (assuming the ability wasn't cancelled)

* Refactor Ability Resolver

* Remove erroneous edits to CardAbility

* Update abilityresolver.js

Events which are cancelled during targeting shouldn't trigger e.g. WC

4034 of 5528 branches covered (72.97%)

10910 of 13045 relevant lines covered (83.63%)

31266.93 hits per line

Source Files on job 5391.1 (CXX=g++-4.9)
  • Tree
  • List 0
  • Changed 245
  • Source Changed 22
  • Coverage Changed 238
Coverage ∆ File Lines Relevant Covered Missed Hits/Line Branch Hits Branch Misses
  • Back to Build 4242
  • Travis Job 5391.1
  • fa24302d on github
  • Prev Job for CXX=g++-4.9 on cote (#5376.1)
  • Next Job for CXX=g++-4.9 on cote (#5392.1)
STATUS · Troubleshooting · Open an Issue · Sales · Support · CAREERS · ENTERPRISE · START FREE · SCHEDULE DEMO
ANNOUNCEMENTS · TWITTER · TOS & SLA · Supported CI Services · What's a CI service? · Automated Testing

© 2026 Coveralls, Inc