1
89%
master: 89%

Ran 01 Feb 2019 12:36AM UTC

Files 256

Run time 18s

Badge

Embed ▾

Committed 01 Feb 2019 12:24AM UTC coverage: 87.17% (-0.05%) from 87.216%

Job # 12831.1

Build Type

push

travis-ci

Committed by

ejona86

Commit Message

core: Fix racy creation/set of the retry Future

This fixes two races: a data race where scheduledRetry is accessed
by cancel() and confusion where scheduledRetry could be set to null by
the schedule()d runnable before it is set by the schedule() return
value.

Although it seems these races can't actually cause problems due to other
conditions/constraints, it's hard to reason about. So let's plug these
preemptively, even if we can't add tests that trigger them.

ScheduledHedging was not specific to hedging, so can now be reused for
this retry case. It was renamed to avoid being misleading.

Coverage Stats

14030 of 16095 relevant lines covered (87.17%)

0.87 hits per line

grpc / grpc-java / 12831 / 1
89%
master: 89%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 12831.1

grpc / grpc-java / 12831 / 1 89% master: 89%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 12831.1

grpc / grpc-java / 12831 / 1
89%
master: 89%

README BADGES
x