2
100%
master: 100%

Ran 16 Jan 2019 05:34AM UTC

Files 29

Run time 2s

Badge

Embed ▾

Committed 16 Jan 2019 01:20AM UTC coverage: 98.831% (-0.008%) from 98.839%

Job # 168.2

Build Type

push

travis-ci

Committed by

web-flow

Commit Message

Test `pop` with default argument (#380)

* Test `pop` with default argument

Adds another case to `test_pop` for stores generally, which merely tests
if `pop` can handle the default argument correctly when no key can be
found.

* Test `pop` with the default value of `None`

Some implementations of `pop` might carelessly set the `default` to
`None` when not passed. However this would make it impossible to
distinguish the case where the user passed `None` for the `default`
intentionally versus not passing anything for the `default`. The result
being both cases would raise a `KeyError`, but the error would be
incorrect in the first case. The usual way of solving this is to create
some dummy object and make that the `default` when if it is not set.
That way one can compare if the dummy object is seen and only raise
then. Thus passing `None` for the `default` would not error, but return
`None` if the `key` does not exist as expected. This test is added to
catch this potential oversight.

* Test `pop` with a non-trivial `bytes` object

Run Details

8282 of 8380 relevant lines covered (98.83%)

0.99 hits per line

jakirkham / zarr / 168 / 2
100%
master: 100%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 168.2

jakirkham / zarr / 168 / 2 100% master: 100%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 168.2

jakirkham / zarr / 168 / 2
100%
master: 100%

README BADGES
x