168
100%

Ran 16 Jan 2019 05:34AM UTC

Jobs 4

Files 29

Run time 4min

Badge

Embed ▾

pending completion

Build # 168

Build Type

push

travis-ci

Committed by

web-flow

Commit Message

Test `pop` with default argument (#380)

* Test `pop` with default argument

Adds another case to `test_pop` for stores generally, which merely tests
if `pop` can handle the default argument correctly when no key can be
found.

* Test `pop` with the default value of `None`

Some implementations of `pop` might carelessly set the `default` to
`None` when not passed. However this would make it impossible to
distinguish the case where the user passed `None` for the `default`
intentionally versus not passing anything for the `default`. The result
being both cases would raise a `KeyError`, but the error would be
incorrect in the first case. The usual way of solving this is to create
some dummy object and make that the `default` when if it is not set.
That way one can compare if the dummy object is seen and only raise
then. Thus passing `None` for the `default` would not error, but return
`None` if the `key` does not exist as expected. This test is added to
catch this potential oversight.

* Test `pop` with a non-trivial `bytes` object

Run Details

8380 of 8380 relevant lines covered (100.0%)

3.96 hits per line

Jobs

ID	Job ID	Ran	Coverage
1	168.1	16 Jan 2019 05:34AM UTC	98.84	Travis Job 168.1
2	168.2	16 Jan 2019 05:34AM UTC	98.83	Travis Job 168.2
3	168.3	16 Jan 2019 05:39AM UTC	98.83	Travis Job 168.3
4	168.4	16 Jan 2019 05:35AM UTC	99.4	Travis Job 168.4

Source Files on build 168

Detailed source file information is not available for this build.

jakirkham / zarr / 168
100%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 168

jakirkham / zarr / 168 100%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 168

jakirkham / zarr / 168
100%

README BADGES
x