10
92%
master: 92%

Ran 12 Feb 2015 04:25AM UTC

Files 73

Run time 727min

Badge

Embed ▾

Committed 12 Feb 2015 04:17AM UTC coverage: 83.697% (-0.009%) from 83.706%

Job # DEPS=false

Build Type

Pull #1333

travis-ci

Committed by

carlsverre

Commit Message

Coroutine exception __context__ leak in python 3

In Python 3 every exception has an auto-attached __context__ exception if it was
raised while an existing exception was being handled.  This is often a very
useful property and allows users to see the underlying cause of many problems.

However, when dealing with async code via coroutines this feature can suddenly
become a pretty big issue.  Namely, if you generator.throw back into a coroutine
to raise an exception in the correct scope, and that coroutine raises an
exception at a later time you can have nested exceptions which shouldn't
logically be nested.

This patch resolves this issue in the coroutine code by moving the gen.throw
outside of the exception handler.  By doing this the user-code scope is able to
later raise exceptions without worrying about inheriting prior exception
context.

Pull Request Pull Request #1333: Coroutine exception __context__ leak in python 3

Coverage Stats

14077 of 16819 relevant lines covered (83.7%)

0.84 hits per line

tornadoweb / tornado / 1457 / 10
92%
master: 92%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 1457.10 (DEPS=false)

tornadoweb / tornado / 1457 / 10 92% master: 92%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 1457.10 (DEPS=false)

tornadoweb / tornado / 1457 / 10
92%
master: 92%

README BADGES
x