1457
92%

Ran 12 Feb 2015 04:18AM UTC

Jobs 14

Files 0

Run time 734min

Badge

Embed ▾

pending completion

Build # 1457

Build Type

Pull #1333

travis-ci

Committed by

carlsverre

Commit Message

Coroutine exception __context__ leak in python 3

In Python 3 every exception has an auto-attached __context__ exception if it was
raised while an existing exception was being handled.  This is often a very
useful property and allows users to see the underlying cause of many problems.

However, when dealing with async code via coroutines this feature can suddenly
become a pretty big issue.  Namely, if you generator.throw back into a coroutine
to raise an exception in the correct scope, and that coroutine raises an
exception at a later time you can have nested exceptions which shouldn't
logically be nested.

This patch resolves this issue in the coroutine code by moving the gen.throw
outside of the exception handler.  By doing this the user-code scope is able to
later raise exceptions without worrying about inheriting prior exception
context.

Pull Request Pull Request #1333: Coroutine exception __context__ leak in python 3

Run Details

85380 of 100910 relevant lines covered (84.61%)

1.4 hits per line

Uncovered Existing Lines

Lines	Coverage	∆	File
1	97.28	0.02%	/home/travis/virtualenv/pypy3-2.4.0/site-packages/tornado-4.2.dev1-py3.2.egg/tornado/gen.py
1	97.28	0.02%	/home/travis/virtualenv/python3.3.5/lib/python3.3/site-packages/tornado-4.2.dev1-py3.3-linux-x86_64.egg/tornado/gen.py

Jobs

ID	Job ID	Ran	Files	Coverage
1	1457.1 (DEPS=true)	12 Feb 2015 04:19AM UTC	0		Travis Job 1457.1
2	1457.2 (DEPS=false)	12 Feb 2015 04:18AM UTC	0		Travis Job 1457.2
3	1457.3 (DEPS=true)	12 Feb 2015 04:20AM UTC	0		Travis Job 1457.3
4	1457.4 (DEPS=false)	12 Feb 2015 04:19AM UTC	73	83.26	Travis Job 1457.4
5	1457.5 (DEPS=true)	12 Feb 2015 03:05PM UTC	72		Travis Job 1457.5
6	1457.6 (DEPS=false)	12 Feb 2015 04:24AM UTC	72	83.07	Travis Job 1457.6
7	1457.7 (DEPS=true)	12 Feb 2015 04:21AM UTC	73	85.48	Travis Job 1457.7
8	1457.8 (DEPS=false)	12 Feb 2015 04:21AM UTC	73	83.74	Travis Job 1457.8
9	1457.9 (DEPS=true)	12 Feb 2015 04:25AM UTC	73	87.75	Travis Job 1457.9
10	1457.10 (DEPS=false)	12 Feb 2015 04:25AM UTC	73	83.7	Travis Job 1457.10
11	1457.11 (DEPS=true)	12 Feb 2015 04:27AM UTC	0		Travis Job 1457.11
12	1457.12 (DEPS=false)	12 Feb 2015 04:27AM UTC	73	83.95	Travis Job 1457.12
13	1457.13 (DEPS=true)	12 Feb 2015 04:33AM UTC	72	83.71	Travis Job 1457.13
14	1457.14 (DEPS=false)	12 Feb 2015 04:34AM UTC	72	83.71	Travis Job 1457.14

Source Files on build 1457

Coverage	∆	File	Lines	Relevant	Covered	Missed	Hits/Line

tornadoweb / tornado / 1457
92%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Uncovered Existing Lines

Jobs

Source Files on build 1457

tornadoweb / tornado / 1457 92%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Uncovered Existing Lines

Jobs

Source Files on build 1457

tornadoweb / tornado / 1457
92%

README BADGES
x