FAForever / server / 2396 / 1
96%
develop: 96%

DEFAULT BRANCH: develop
Ran
Files 38
Run time 1s
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst
coverage: 80.944% (+1.1%) from 79.809%
2396.1

push

travis-ci

Rackover 
Refactor command handling (#381)

* Refactored command handlers. Each case should now have the same error handling

* Added test for connecting players to their peers

* Move docstring to appropriate location

* Fix conditional

* Add test for all branches of handle_game_option

* Fix subtle bugs in handle_game_option

* Cleanup linter errors

* Add test for GameMods activated packet. What is the point of this packet?

* Assuming this is what the packet actually looks like, now string values work too.

* Added test for AIOption

* Added test for ClearSlot

* Added test for GameState ended

* Make sure auth error messages are always the same

* Removed dead code

Not only is it dead, but this code looks sketcy as well. Plain SHA should not be used for signature verification because of length-extension attacks. It's always better to use HMAC for signing messages.

* Only ignore invalid maps

Don't break off the whole request just because one entry had an unrecognized map type. Also use fetchall() because that (probably) has better performance

* Add test for send_coop_maps. Requires FAForever/db#183

* Remane arg

* Skip test_send_coop_maps until test data is available

* Make command handler table static

* Remove unused imports

* Some code review changes.

* Checkout updated test-data.sql

* Revert "Checkout updated test-data.sql"

This reverts commit e0fba54f3.

* Don't unpack row tuple until after `None` check.

* Remove unused imports

* Change function names to be snake case

* Replace _logger with log

* Add some useful typing

* Add backticks to sql queries

* Remove functools

* Some more typing

* Apparently not valid syntax in python 3.5

* Fix imports

* Fix function rename in tests.

* Txt file does not need to be executable

* Show pytest warnings

* Remove 'test' from the start of things which aren't tests

* Use logger from @wi... (continued)

2417 of 2986 relevant lines covered (80.94%)

0.81 hits per line

Source Files on job 2396.1