1
97%
master: 97%

Ran 04 Dec 2018 08:32AM UTC

Files 12

Run time 7min

Badge

Embed ▾

Committed 04 Dec 2018 08:23AM UTC coverage: 94.61%. Remained the same

Job # 238.1

Build Type

push

travis-ci

Committed by

web-flow

Commit Message

Rework typechecking of optional/nonempty quantifiers (#52)

Removes a few workarounds / special cases for static validation of optional & nonempty type compatibility. They are now checked more rigorously by default, so for example any use of `T?` where `T` is expected requires an explicit coercion such as with select_first(). But to accommodate older WDLs which depend on less strictness, supplying WDL.load(..., check_quant=False) relaxes these static validation checks.

The WDL specification is vague as to how strict this typechecking should be; this compromise should let us accommodate older WDLs without necessarily reproducing every detail of what Cromwell does and doesn't enforce for different WDL versions. cf. https://github.com/openwdl/wdl/issues/271

Expands the OptionalCoercion linter to warn of constructs that validate only when check_quant=False.

Closes #50

Run Details

1966 of 2078 relevant lines covered (94.61%)

0.95 hits per line

chanzuckerberg / miniwdl / 238 / 1
97%
master: 97%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 238.1

chanzuckerberg / miniwdl / 238 / 1 97% master: 97%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 238.1

chanzuckerberg / miniwdl / 238 / 1
97%
master: 97%

README BADGES
x