238
97%

Ran 04 Dec 2018 08:32AM UTC

Jobs 1

Files 12

Run time 12min

Badge

Embed ▾

pending completion

Build # 238

Build Type

push

travis-ci

Committed by

web-flow

Commit Message

Rework typechecking of optional/nonempty quantifiers (#52)

Removes a few workarounds / special cases for static validation of optional & nonempty type compatibility. They are now checked more rigorously by default, so for example any use of `T?` where `T` is expected requires an explicit coercion such as with select_first(). But to accommodate older WDLs which depend on less strictness, supplying WDL.load(..., check_quant=False) relaxes these static validation checks.

The WDL specification is vague as to how strict this typechecking should be; this compromise should let us accommodate older WDLs without necessarily reproducing every detail of what Cromwell does and doesn't enforce for different WDL versions. cf. https://github.com/openwdl/wdl/issues/271

Expands the OptionalCoercion linter to warn of constructs that validate only when check_quant=False.

Closes #50

Run Details

1966 of 2078 relevant lines covered (94.61%)

0.95 hits per line

Jobs

ID	Job ID	Ran	Files	Coverage
1	238.1	04 Dec 2018 08:32AM UTC	0	94.61	Travis Job 238.1

Source Files on build 238

Detailed source file information is not available for this build.

chanzuckerberg / miniwdl / 238
97%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 238

chanzuckerberg / miniwdl / 238 97%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 238

chanzuckerberg / miniwdl / 238
97%

README BADGES
x