• Home
  • Features
  • Pricing
  • Docs
  • Announcements
  • Sign In

bookbrainz / bookbrainz-site / 1869 / 1
61%
master: 61%

Build:
DEFAULT BRANCH: master
Ran 07 Nov 2018 11:59AM UTC
Files 148
Run time 1min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst

07 Nov 2018 11:54AM UTC coverage: 42.512% (-0.08%) from 42.591%
CXX=g++-4.8

push

travis-ci

MonkeyDo
feat(display): Display Entity Aliases on entity pages (#218)

* Add getEntityAlias function

Added the getEntityAlias function so that the aliases can be obtained (from https://github.com/Ge0rg3/bookbrainz-site/edit/show-alias/src/client/components/pages/entities/title.js).

* Show aliases under title

Uses the new getEntityAlias method to retrieve, and then show an entity's aliases.
Also swaps round the definitions in EntityTitle to make them alphabetic :)

* Title entity styling fixes

Fixed styling for Travis:
  32:57  error  Trailing spaces not allowed                 no-trailing-spaces
  37:1   error  Expected indentation of 3 tabs but found 4  indent

* getEntityAlias Styling Fixes

Fixed the following for Travis:
  173:1  error  Expected indentation of 2 tabs but found 9                            indent
  174:1  error  Expected indentation of 2 tabs but found 9                            indent
  175:1  error  Expected indentation of 2 tabs but found 9                            indent
  178:2  error  Closing curly brace appears on the same line as the subsequent block  brace-style
  178:9  error  Unnecessary 'else' after 'return'                                     no-else-return

* Removed trailing space

Thanks Travis

* Import renamed function

getEntityAlias will be renamed to getEntityAliases, so this is changed to fit that.

* getEntityAliases functionality/name change.

"getEntityAlias" -> "getEntityAliases".
Aliases with the same ID are now removed, instead of the same name, so that duplicates are more easily identifiable.

* Rename getEntityAliases -> getEntitySecondaryAliases

Renamed getEntityAliases -> getEntitySecondaryAliases as suggested on a review.

* Rename getEntityAliases -> getEntitySecondaryAliases

Rename getEntityAliases -> getEntitySecondaryAliases as suggested in a review.

159 of 1334 branches covered (11.92%)

1621 of 3813 relevant lines covered (42.51%)

4.12 hits per line

Source Files on job 1869.1 (CXX=g++-4.8)
  • Tree
  • List 0
  • Changed 2
  • Source Changed 2
  • Coverage Changed 2
Coverage ∆ File Lines Relevant Covered Missed Hits/Line Branch Hits Branch Misses
  • Back to Build 1830
  • Travis Job 1869.1
  • 3ce935c8 on github
  • Prev Job for CXX=g++-4.8 on master (#1848.1)
  • Next Job for CXX=g++-4.8 on master (#1885.2)
STATUS · Troubleshooting · Open an Issue · Sales · Support · CAREERS · ENTERPRISE · START FREE · SCHEDULE DEMO
ANNOUNCEMENTS · TWITTER · TOS & SLA · Supported CI Services · What's a CI service? · Automated Testing

© 2026 Coveralls, Inc