bookbrainz / bookbrainz-site / 1869

61%

push

travis-ci

feat(display): Display Entity Aliases on entity pages (#218)

* Add getEntityAlias function

Added the getEntityAlias function so that the aliases can be obtained (from https://github.com/Ge0rg3/bookbrainz-site/edit/show-alias/src/client/components/pages/entities/title.js).

* Show aliases under title

Uses the new getEntityAlias method to retrieve, and then show an entity's aliases.
Also swaps round the definitions in EntityTitle to make them alphabetic :)

* Title entity styling fixes

Fixed styling for Travis:
  32:57  error  Trailing spaces not allowed                 no-trailing-spaces
  37:1   error  Expected indentation of 3 tabs but found 4  indent

* getEntityAlias Styling Fixes

Fixed the following for Travis:
  173:1  error  Expected indentation of 2 tabs but found 9                            indent
  174:1  error  Expected indentation of 2 tabs but found 9                            indent
  175:1  error  Expected indentation of 2 tabs but found 9                            indent
  178:2  error  Closing curly brace appears on the same line as the subsequent block  brace-style
  178:9  error  Unnecessary 'else' after 'return'                                     no-else-return

* Removed trailing space

Thanks Travis

* Import renamed function

getEntityAlias will be renamed to getEntityAliases, so this is changed to fit that.

* getEntityAliases functionality/name change.

"getEntityAlias" -> "getEntityAliases".
Aliases with the same ID are now removed, instead of the same name, so that duplicates are more easily identifiable.

* Rename getEntityAliases -> getEntitySecondaryAliases

Renamed getEntityAliases -> getEntitySecondaryAliases as suggested on a review.

* Rename getEntityAliases -> getEntitySecondaryAliases

Rename getEntityAliases -> getEntitySecondaryAliases as suggested in a review.

159 of 1334 branches covered (11.92%)

8 of 8 new or added lines in 2 files covered. (100.0%)

1621 of 3813 relevant lines covered (42.51%)

8.24 hits per line